Repository navigation
refactor(ui): QueryaIconButton, QueryaSearchField and QueryaTabStrip off shadcn - #1413
Merged
Merged
Conversation
…no longer import shadcn The colour scheme comes from QueryaTheme, gaps are SizedBoxes, the tab label is a plain Text with the same size and weight, and widgets types are taken from material. The three files leave the shadcn allow-list. Part of #1365.
github-actions
Bot
added
epic
…ueryaThemeScope Widgets in tests and dialogs can be built under the UI library's theme without a QueryaThemeScope; context.queryaTheme asserts there. context.colors is the same scheme the old code read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1365 (does not close it)
Second migration under the ratchet guard (#1409), after #1412: three more kit controls stop importing
package:shadcn_flutterand leave the allow-list in the same change.querya_icon_button.dartTheme.of(context).colorScheme,Gapcontext.queryaTheme.colorScheme,SizedBoxquerya_search_field.dartTheme.of, unprefixedValueChanged/CallbackShortcuts/SingleActivatorcontext.queryaTheme.colorScheme,material.*querya_tab_strip.dartTheme.of,Text(...).small().semiBold()/.muted(),Gap, unprefixedListenable/ListenableBuildercontext.queryaTheme.colorScheme, a plainText(14 px, 20 px line, w600 selected / w400 muted),SizedBox,material.*QueryaTheme.colorSchemeis the scheme the app passes to its shadcn theme, so the colours are the same values. The tab label keeps its 14 px / 20 px line and weights.Conflict note
The allow-list lines of this PR and of #1412 are neighbours; whichever merges second needs a trivial merge of that file.
Not in this PR
Dropdown, action menu and dialog card (shadcn
radiusXxl), and everything that needs a button (querya_empty_state,querya_modal_dialog,querya_action_button) wait forQueryaButton(#1408) and the theme-access decision.Not run locally; CI is the check.